nastra commented on PR #10939: URL: https://github.com/apache/iceberg/pull/10939#issuecomment-2293295952
> I'm ok with this. Personally I amend + force push quite a bit but if folks find that style hard to review, I will aim for changing that. When reviewing I go through the files again and the targeted review comments rather than the diff between commits but of course recognize that everyone has their style. I do agree with Amogh as I also amend and force push quite often and it hasn't been brought up as an issue, but I'm fine changing this and only push update commits if people think this is easier when reviewing. Personally speaking, I do always review the entire diff and use the GH function to mark reviewed files as **Viewed**. If an update to that file has been pushed, then GH will properly show that there are new changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
