stevenzwu commented on code in PR #10832: URL: https://github.com/apache/iceberg/pull/10832#discussion_r1717648578
########## flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java: ########## @@ -225,10 +254,12 @@ public static class Builder<T> { private SplitAssignerFactory splitAssignerFactory; private SerializableComparator<IcebergSourceSplit> splitComparator; private ReaderFunction<T> readerFunction; + private TypeInformation<T> outputTypeInfo; Review Comment: created a separate PR to replace `ReaderFunction` with new `Reader` interface: https://github.com/apache/iceberg/pull/10944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org