pvary commented on code in PR #10832:
URL: https://github.com/apache/iceberg/pull/10832#discussion_r1713675699
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -464,6 +519,15 @@ public Builder<T> watermarkColumnTimeUnit(TimeUnit
timeUnit) {
return this;
}
+ /**
+ * Optional. Default is no watermark strategy. Only relevant if using the
{@link
+ * Builder#buildStream(StreamExecutionEnvironment)}.
+ */
+ public Builder<T> watermarkStrategy(WatermarkStrategy<T> newStrategy) {
Review Comment:
Is there a way to provide a useful `WatermarkStrategy`?
I think it is possible to provide a useful `TimestampAssigner`, but I don't
see how can someone provide a useful `WatermarkGenerator`. The only possible
way to generate watermarks are with the `watermarkColumn` is provided, but even
then the `WatermarkGenerator` should not be used.
Do I miss something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
