pvary commented on code in PR #10832:
URL: https://github.com/apache/iceberg/pull/10832#discussion_r1713708664


##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -545,5 +579,66 @@ public IcebergSource<T> build() {
           table,
           emitter);
     }
+
+    /**
+     * Build the {@link IcebergSource} and create a {@link DataStream} from 
the source.
+     *
+     * @return data stream from the Iceberg source
+     */
+    public DataStream<T> buildStream(StreamExecutionEnvironment env) {

Review Comment:
   The sentence about `env` is also true for `outputTypeInfo`, and 
`watermarkStrategy`. Maybe adding them as a parameter would be reasonable too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to