pvary commented on code in PR #10832:
URL: https://github.com/apache/iceberg/pull/10832#discussion_r1713702861
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -503,28 +569,10 @@ public IcebergSource<T> build() {
new
OrderedSplitAssignerFactory(SplitComparators.watermark(watermarkExtractor));
}
- ScanContext context = contextBuilder.build();
+ this.context = contextBuilder.build();
Review Comment:
This is ugly as hell.
Side-effect of the build method....
Maybe creating an `init()` with all the side-effects?
And then `build()` which uses the initialized attributes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
