stevenzwu commented on code in PR #10832:
URL: https://github.com/apache/iceberg/pull/10832#discussion_r1720850526
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -464,6 +519,15 @@ public Builder<T> watermarkColumnTimeUnit(TimeUnit
timeUnit) {
return this;
}
+ /**
+ * Optional. Default is no watermark strategy. Only relevant if using the
{@link
+ * Builder#buildStream(StreamExecutionEnvironment)}.
+ */
+ public Builder<T> watermarkStrategy(WatermarkStrategy<T> newStrategy) {
Review Comment:
will remove `WatermarkStrategy` from here. we can always add another
`buildStream` with a new arg in the future if there is really a need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
