sl255051 commented on code in PR #10678:
URL: https://github.com/apache/iceberg/pull/10678#discussion_r1702998105


##########
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##########
@@ -442,9 +456,10 @@ private Types.NestedField findSourceColumn(String 
sourceName) {
     Builder identity(String sourceName, String targetName) {
       Types.NestedField sourceColumn = findSourceColumn(sourceName);
       checkAndAddPartitionName(targetName, sourceColumn.fieldId());
+      String normalizedTargetName = caseSensitive ? targetName : 
targetName.toLowerCase();

Review Comment:
   I've reverted normalization of `targetName` in those methods too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to