rdblue commented on code in PR #10678:
URL: https://github.com/apache/iceberg/pull/10678#discussion_r1702020422
##########
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##########
@@ -442,9 +456,10 @@ private Types.NestedField findSourceColumn(String
sourceName) {
Builder identity(String sourceName, String targetName) {
Types.NestedField sourceColumn = findSourceColumn(sourceName);
checkAndAddPartitionName(targetName, sourceColumn.fieldId());
+ String normalizedTargetName = caseSensitive ? targetName :
targetName.toLowerCase();
Review Comment:
Yes, I didn't intend to change the visibility of any of the methods. The new
methods should all be private, though.
I think that this should be done for all of the configuration methods that
create a partition name (`targetName`) instead of normalizing to lower case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
