rdblue commented on code in PR #10678:
URL: https://github.com/apache/iceberg/pull/10678#discussion_r1707655607
##########
api/src/main/java/org/apache/iceberg/PartitionSpec.java:
##########
@@ -450,13 +459,21 @@ Builder identity(String sourceName, String targetName) {
return this;
}
+ Builder identity(String sourceName, String targetName) {
+ return identity(findSourceColumn(sourceName), targetName);
+ }
Review Comment:
Nit: for the other cases, the methods are in a different order. That order
also keeps the method signature line unchanged. I'd just move this above the
`private` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
