singhpk234 commented on code in PR #10814:
URL: https://github.com/apache/iceberg/pull/10814#discussion_r1700621371
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##########
@@ -296,19 +302,18 @@ private Map<Integer, Long>
lastCommittedOffsetsForTable(Table table, String bran
return ImmutableMap.of();
}
- @Override
- void stop() {
Review Comment:
I see, I was mostly comming from stop calling super.Stop() if it's being
called from some where for sure then we should be good we just wanna make sure
all the resources gets cleaned up, thanks for explanation !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
