bryanck commented on code in PR #10814:
URL: https://github.com/apache/iceberg/pull/10814#discussion_r1700611845
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##########
@@ -218,6 +220,10 @@ private void commitToTable(
.filter(distinctByKey(deleteFile -> deleteFile.path().toString()))
.collect(Collectors.toList());
+ if (terminated) {
+ throw new ConnectException("Coordinator is terminated, commit aborted");
+ }
Review Comment:
I felt putting it as close as possible to the commit was best, so if
`terminate` is called it will prevent the commit ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
