bryanck commented on code in PR #10814:
URL: https://github.com/apache/iceberg/pull/10814#discussion_r1700608998
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##########
@@ -296,19 +302,18 @@ private Map<Integer, Long>
lastCommittedOffsetsForTable(Table table, String bran
return ImmutableMap.of();
}
- @Override
- void stop() {
Review Comment:
We still call it to clean up the Kafka consumer and producer. The consumer
isn't thread safe so I left that call on the Coordinator thread, rather than
the main task thread. It isn't ideal having both a `terminate` and a `stop`,
though this was the best I came up with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
