singhpk234 commented on code in PR #10814:
URL: https://github.com/apache/iceberg/pull/10814#discussion_r1700594254
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##########
@@ -218,6 +220,10 @@ private void commitToTable(
.filter(distinctByKey(deleteFile -> deleteFile.path().toString()))
.collect(Collectors.toList());
+ if (terminated) {
+ throw new ConnectException("Coordinator is terminated, commit aborted");
+ }
Review Comment:
[Q] How early in code flow, should we fail, can we put this check in the
beginning ?
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##########
@@ -296,19 +302,18 @@ private Map<Integer, Long>
lastCommittedOffsetsForTable(Table table, String bran
return ImmutableMap.of();
}
- @Override
- void stop() {
Review Comment:
[Q] wondering if we should still call Channel#stop()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
