singhpk234 commented on code in PR #10814:
URL: https://github.com/apache/iceberg/pull/10814#discussion_r1700619518
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##########
@@ -218,6 +220,10 @@ private void commitToTable(
.filter(distinctByKey(deleteFile -> deleteFile.path().toString()))
.collect(Collectors.toList());
+ if (terminated) {
+ throw new ConnectException("Coordinator is terminated, commit aborted");
+ }
Review Comment:
yup, was mostly comming from the case where we entered the `commitToTable`
block and the terminate was flipped, we could save on load table etc.., it
seems like it will always be a race, make sense to check just before the commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
