szehon-ho commented on PR #10793: URL: https://github.com/apache/iceberg/pull/10793#issuecomment-2257706966
Thanks @amogh-jahagirdar. I guess I need to give the context. In https://github.com/apache/iceberg/pull/10288#discussion_r1691077522 we realize that in fact ndv as defined by theta-sketch algorithm and java library is a double, and the fact that we have stored it is a long means some precision is missing. I am actually more in favor of making it a double, @findepi mention it is not too significant in the long run and favors keeping it a long. But above all, converting now from long to double in trino side is backward incompatible. Hence, was hoping that we can bundle this together with the bump to v2 in #10549 to allow decimal here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
