findepi commented on PR #10793: URL: https://github.com/apache/iceberg/pull/10793#issuecomment-2256968863
> misinterpreted this pr to support double as per [#10288 (comment)](https://github.com/apache/iceberg/pull/10288#discussion_r1691077522) . sorry for the confusion! in that PR review thread i was trying not to prescribe which way we should go and just outline consequences of using doubles clarifying the spec to imply long values is just one of the ways and this is what this PR is doing. clarifying the spec to imply fractional values is some other option. (I am slightly less in favor of it, so i didn't create a PR with it.) > I think we should still do this for completness, but as theta-sketch-v2? The wording used for `apache-datasketches-theta-v1` should have been better and clearly define both: allowed values and their representation. I.e. it was not specified what values are allowed and how they are represented. This PR should not be understood as prohibiting fractional values. Rather, it should be seen as clarification of what's allowed and what's not, and as such shouldn't need a new version of the sketch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
