emkornfield commented on code in PR #10793: URL: https://github.com/apache/iceberg/pull/10793#discussion_r1697230444
########## format/puffin-spec.md: ########## @@ -121,7 +121,9 @@ distinct values converted to bytes using Iceberg's single-value serialization. The blob metadata for this blob may include following properties: -- `ndv`: estimate of number of distinct values, derived from the sketch. +- `ndv`: estimate of number of distinct values, derived from the sketch, Review Comment: Perhaps providing examples of allowed and not allowed values would also help with the clarification -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
