szehon-ho commented on code in PR #10793: URL: https://github.com/apache/iceberg/pull/10793#discussion_r1695559265
########## format/puffin-spec.md: ########## @@ -121,7 +121,9 @@ distinct values converted to bytes using Iceberg's single-value serialization. The blob metadata for this blob may include following properties: -- `ndv`: estimate of number of distinct values, derived from the sketch. +- `ndv`: estimate of number of distinct values, derived from the sketch, + stored as non-negative integer value represented using decimal digits Review Comment: Is 'integer' necessary? Not sure if its just me, but does it add confusion (i initially interpret it to mean 'number without decimal point')? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
