szehon-ho commented on PR #10793: URL: https://github.com/apache/iceberg/pull/10793#issuecomment-2257148519
Yes this pr as is should not require a spec change. > The wording used for apache-datasketches-theta-v1 should have been better and clearly define both: allowed values and their representation. I.e. it was not specified what values are allowed and how they are represented. > This PR should not be understood as prohibiting fractional values. Rather, it should be seen as clarification of what's allowed and what's not, and as such shouldn't need a new version of the sketch. Sorry I am still confused :( , this pr currently prohibits fractional value in this particular metadata "ndv" doesnt it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
