rdblue commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r1676561247
##########
core/src/main/java/org/apache/iceberg/BaseSnapshot.java:
##########
@@ -143,7 +201,24 @@ private void cacheManifests(FileIO fileIO) {
if (allManifests == null) {
// if manifests isn't set, then the snapshotFile is set and should be
read to get the list
- this.allManifests =
ManifestLists.read(fileIO.newInputFile(manifestListLocation));
+ InputFile manifestListInputFile =
fileIO.newInputFile(manifestListLocation);
Review Comment:
I think that the change I suggested above is needed to avoid decryption in
`SnapshotParser`. The parser should create a `ManifestListFile` with the
encrypted key metadata and wrapped encryption key. Then when the manifest list
is read by this `fileIO`, the key metadata is decrypted and passed in to create
the decrypting stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
