rdblue commented on code in PR #7770: URL: https://github.com/apache/iceberg/pull/7770#discussion_r1676560690
########## api/src/main/java/org/apache/iceberg/ManifestListFile.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.io.Serializable; + +public class ManifestListFile implements Serializable { + private final String location; + private final String wrappedKeyMetadata; + private final long size; + private final String wrappedKeyEncryptionKey; + + public ManifestListFile( + String location, String wrappedKeyMetadata, long size, String wrappedKeyEncryptionKey) { + this.location = location; + this.wrappedKeyMetadata = wrappedKeyMetadata; + this.size = size; + this.wrappedKeyEncryptionKey = wrappedKeyEncryptionKey; + } + + /** Location of manifest list file. */ + public String location() { + return location; + } + + /** + * Key metadata for manifest list in encrypted table. + * + * @return encrypted and base64-encoded key metadata for the manifest list file + */ + public String wrappedKeyMetadata() { Review Comment: I think that this needs to be `ByteBuffer encryptedKeyMetadata` instead. As I noted in `SnapshotParser`, I don't think that the key metadata should be decrypted there. It should remain encrypted until this object is passed into `EncryptingFileIO`. Then the `FileIO` can unwrap the key used to encrypt this, create a `KeyMetadata`, and create the `InputFile` that can read the `ManifestListFile`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
