rdblue commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r1676510282
##########
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##########
@@ -106,6 +124,10 @@ public static String toJson(Snapshot snapshot, boolean
pretty) {
}
static Snapshot fromJson(JsonNode node) {
+ return fromJson(node, null);
+ }
+
+ static Snapshot fromJson(JsonNode node, EncryptionManager encryption) {
Review Comment:
I don't think that this should use the encryption manager. `SnapshotParser`
should only be responsible for encoding and decoding the snapshot fields, not
for encrypting and decrypting. The logic added here is really complex and
should be handled elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
