rdblue commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r1676544528
##########
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##########
@@ -147,6 +169,42 @@ static Snapshot fromJson(JsonNode node) {
if (node.has(MANIFEST_LIST)) {
// the manifest list is stored in a manifest list file
String manifestList = JsonUtil.getString(MANIFEST_LIST, node);
+
+ ByteBuffer manifestListKeyMetadata = null;
+ ByteBuffer wrappedManifestListKeyMetadata = null;
+ String wrappedKeyEncryptionKey = null;
+
+ // Manifest list can be encrypted
+ if (node.has(MANIFEST_LIST_KEY_METADATA)) {
+ // Decode and decrypt manifest list key with metadata key
+ String manifestListKeyMetadataString =
JsonUtil.getString(MANIFEST_LIST_KEY_METADATA, node);
+ wrappedManifestListKeyMetadata =
+
ByteBuffer.wrap(Base64.getDecoder().decode(manifestListKeyMetadataString));
+
+ NativeEncryptionKeyMetadata nativeWrappedKeyMetadata =
+ EncryptionUtil.parseKeyMetadata(wrappedManifestListKeyMetadata);
+ ByteBuffer wrappedManifestListKey =
nativeWrappedKeyMetadata.encryptionKey();
Review Comment:
This key is not wrapped, it is encrypted. I think that should be clear so
I'd rename the variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
