rdblue commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r1676495226
##########
core/src/main/java/org/apache/iceberg/BaseSnapshot.java:
##########
@@ -143,7 +201,24 @@ private void cacheManifests(FileIO fileIO) {
if (allManifests == null) {
// if manifests isn't set, then the snapshotFile is set and should be
read to get the list
- this.allManifests =
ManifestLists.read(fileIO.newInputFile(manifestListLocation));
+ InputFile manifestListInputFile =
fileIO.newInputFile(manifestListLocation);
Review Comment:
Why not add a call to `EncryptingFileIO` to open a `ManifestListFile` so
that we can do the same thing here that we do for `ManifestFile`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
