amogh-jahagirdar commented on code in PR #10369:
URL: https://github.com/apache/iceberg/pull/10369#discussion_r1665910677
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -991,7 +991,7 @@ public Builder assignUUID(String newUuid) {
// it is only safe to set the format version directly while creating tables
// in all other cases, use upgradeFormatVersion
- private Builder setInitialFormatVersion(int newFormatVersion) {
+ public Builder setInitialFormatVersion(int newFormatVersion) {
Review Comment:
@hantangwangd I've raised a PR to your branch
https://github.com/hantangwangd/iceberg/pull/1/files, but missed @nastra on the
lazy formatVersion initialization. Not sure entirely what that meant, but in my
approach we add a new `buildFromEmpty(int formatVersion` API so that the format
version is only initialized once and never mutated (unless going through an
actual upgrade API call)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
