nastra commented on code in PR #10369:
URL: https://github.com/apache/iceberg/pull/10369#discussion_r1625500488
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -991,7 +991,7 @@ public Builder assignUUID(String newUuid) {
// it is only safe to set the format version directly while creating tables
// in all other cases, use upgradeFormatVersion
- private Builder setInitialFormatVersion(int newFormatVersion) {
+ public Builder setInitialFormatVersion(int newFormatVersion) {
Review Comment:
one alternative would be to lazily initialize `formatVersion` inside
`TableMetadata.Builder` so that calling `setInitialFormatVersion` wouldn't be
necessary from `CatalogHandlers` during table creation. Let's see what others
think here
/cc @aokolnychyi @rdblue @amogh-jahagirdar @RussellSpitzer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
