nastra commented on code in PR #10369:
URL: https://github.com/apache/iceberg/pull/10369#discussion_r1624512760
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -374,8 +374,7 @@ private static TableMetadata create(TableOperations ops,
UpdateTableRequest requ
// the only valid requirement is that the table will be created
request.requirements().forEach(requirement ->
requirement.validate(ops.current()));
- TableMetadata.Builder builder = TableMetadata.buildFromEmpty();
- request.updates().forEach(update -> update.applyTo(builder));
+ TableMetadata.Builder builder =
TableMetadata.buildFromMetadataUpdates(request.updates());
Review Comment:
I would just inline the fix here when iterating `updates`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
