amogh-jahagirdar commented on code in PR #10369:
URL: https://github.com/apache/iceberg/pull/10369#discussion_r1653278618
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -375,7 +376,16 @@ private static TableMetadata create(TableOperations ops,
UpdateTableRequest requ
request.requirements().forEach(requirement ->
requirement.validate(ops.current()));
TableMetadata.Builder builder = TableMetadata.buildFromEmpty();
- request.updates().forEach(update -> update.applyTo(builder));
+ request
+ .updates()
+ .forEach(
+ update -> {
+ if (update instanceof UpgradeFormatVersion) {
+ builder.setInitialFormatVersion(((UpgradeFormatVersion)
update).formatVersion());
Review Comment:
Or an alternative is to add a `buildFromEmpty(int formatVersion)` API and
apply the updates. Either way, agree with the idea that the format version
should be defined once upfront when building a new table metadata instance for
creation rather than mutate it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
