hantangwangd commented on code in PR #10369:
URL: https://github.com/apache/iceberg/pull/10369#discussion_r1665997350
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -375,7 +376,16 @@ private static TableMetadata create(TableOperations ops,
UpdateTableRequest requ
request.requirements().forEach(requirement ->
requirement.validate(ops.current()));
TableMetadata.Builder builder = TableMetadata.buildFromEmpty();
- request.updates().forEach(update -> update.applyTo(builder));
+ request
+ .updates()
+ .forEach(
+ update -> {
+ if (update instanceof UpgradeFormatVersion) {
+ builder.setInitialFormatVersion(((UpgradeFormatVersion)
update).formatVersion());
Review Comment:
@amogh-jahagirdar Thank you for the change, that makes sense. I absorbed it
into this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]