stevenzwu commented on code in PR #10370:
URL: https://github.com/apache/iceberg/pull/10370#discussion_r1613698660
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -124,7 +124,7 @@ public void testBoundedWithSavepoint() throws Exception {
GenericAppenderHelper dataAppender =
new GenericAppenderHelper(
sourceTableResource.table(), FileFormat.PARQUET, TEMPORARY_FOLDER);
- for (int i = 0; i < 4; ++i) {
+ for (int i = 0; i < 20; ++i) {
Review Comment:
> but what happens if you try to create a savepoint when some of the tasks
are not started yet?
I see. so the savepoint is triggered before all tasks in running state. that
would explain the problem/exception.
If we want to keep this test, we need to achieve these
- make sure the bounded test doesn't complete before a checkpoint/savepoint
is triggered
- make sure all tasks are in running state before a checkpoint/savepoint is
triggered
I am always fine with disabling a flaky test first until we figure out a
proper solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
