pvary commented on code in PR #10370:
URL: https://github.com/apache/iceberg/pull/10370#discussion_r1612213520


##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -124,7 +124,7 @@ public void testBoundedWithSavepoint() throws Exception {
     GenericAppenderHelper dataAppender =
         new GenericAppenderHelper(
             sourceTableResource.table(), FileFormat.PARQUET, TEMPORARY_FOLDER);
-    for (int i = 0; i < 4; ++i) {
+    for (int i = 0; i < 20; ++i) {

Review Comment:
   Not sure that this is the same issue that I have found before, but if one TM 
is slow to start, then other TMs might finish some splits, and get a new one. 
So when the slow starting TM is finally ready, the there are no more splits 
available. So it could immediately finish (no checkpoint in this case) 
   
   If I remember correctly, there is some way on the minicluster to wait until 
all of the TMs are started. Which could help, but there are no theoretical 
guarantees that the checkpoint could finish, even in this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to