stevenzwu commented on code in PR #10370:
URL: https://github.com/apache/iceberg/pull/10370#discussion_r1611949141
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -124,7 +124,7 @@ public void testBoundedWithSavepoint() throws Exception {
GenericAppenderHelper dataAppender =
new GenericAppenderHelper(
sourceTableResource.table(), FileFormat.PARQUET, TEMPORARY_FOLDER);
- for (int i = 0; i < 4; ++i) {
+ for (int i = 0; i < 20; ++i) {
Review Comment:
from the stack trace that you included in the GitHub issue, it seems that
some source tasks finished before the savepoint is triggered. old code should
produce 4 files (each with 2 records). I think the real problem is probably all
files was bundled in one `CombinedScanTask`. As a result, one subtask is idle
and finished early.
this will not fix the flakiness. we need to change the target split size to
1 byte to avoid bundling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
