pvary commented on code in PR #10370:
URL: https://github.com/apache/iceberg/pull/10370#discussion_r1612804231


##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -124,7 +124,7 @@ public void testBoundedWithSavepoint() throws Exception {
     GenericAppenderHelper dataAppender =
         new GenericAppenderHelper(
             sourceTableResource.table(), FileFormat.PARQUET, TEMPORARY_FOLDER);
-    for (int i = 0; i < 4; ++i) {
+    for (int i = 0; i < 20; ++i) {

Review Comment:
   You can create a savepoint if some of the tasks are finished, but what 
happens if you try to create a savepoint when some of the tasks are not started 
yet?
   
   Does the savepoint fail, or just wait until the tasks are started?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to