stevenzwu commented on code in PR #10370:
URL: https://github.com/apache/iceberg/pull/10370#discussion_r1612756537
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -124,7 +124,7 @@ public void testBoundedWithSavepoint() throws Exception {
GenericAppenderHelper dataAppender =
new GenericAppenderHelper(
sourceTableResource.table(), FileFormat.PARQUET, TEMPORARY_FOLDER);
- for (int i = 0; i < 4; ++i) {
+ for (int i = 0; i < 20; ++i) {
Review Comment:
checking this test method again. we are testing savepoint trigger with
bounded source. it is possible that splits are exhausted and source operator
reached finished state before the savepoint was triggered.
But Flink has this feature to support checkpoint even if part of the graph
finished. If that is the case, savepoint should still succeed.
https://nightlies.apache.org/flink/flink-docs-master/docs/dev/datastream/fault-tolerance/checkpointing/#checkpointing-with-parts-of-the-graph-finished
We are probably still missing sth
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
