nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584248713
##########
data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java:
##########
@@ -243,10 +240,11 @@ public void
testEqualityDeletePlanningStatsNullValueWithAllNullDeletes() throws
tasks = Lists.newArrayList(tasksIterable);
}
- Assert.assertEquals("Should produce one task", 1, tasks.size());
+ Assertions.assertThat(tasks.size()).isEqualTo(1).as("Should produce one
task");
Review Comment:
same as above
##########
data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java:
##########
@@ -243,10 +240,11 @@ public void
testEqualityDeletePlanningStatsNullValueWithAllNullDeletes() throws
tasks = Lists.newArrayList(tasksIterable);
}
- Assert.assertEquals("Should produce one task", 1, tasks.size());
+ Assertions.assertThat(tasks.size()).isEqualTo(1).as("Should produce one
task");
FileScanTask task = tasks.get(0);
- Assert.assertEquals(
- "Should have delete file, data contains a null value", 1,
task.deletes().size());
+ Assertions.assertThat(task.deletes().size())
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
