nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584316540


##########
data/src/test/java/org/apache/iceberg/data/orc/TestGenericReadProjection.java:
##########
@@ -33,7 +33,8 @@ public class TestGenericReadProjection extends 
TestReadProjection {
   @Override
   protected Record writeAndRead(String desc, Schema writeSchema, Schema 
readSchema, Record record)
       throws IOException {
-    File file = temp.newFile(desc + ".orc");
+
+    File file = File.createTempFile("junit", null, temp);

Review Comment:
   ```suggestion
       File file = File.createTempFile(desc, ".orc", temp);
   ```
   
   we want to keep the `.orc` suffix here. Also please remove the unnecessary 
newline that was added right above this line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to