nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584310664
##########
data/src/test/java/org/apache/iceberg/data/TestLocalScan.java:
##########
@@ -378,11 +368,11 @@ public void testProjectWithSchema() {
GenericRecord.create(schema)
.copy(ImmutableMap.of("id", 2L, "data", "falafel", "_spec_id", 0,
"_pos", 2L));
expectedRecord.setField("_partition", null);
- Assert.assertEquals(expectedRecord, iterator.next());
- Assert.assertFalse(iterator.hasNext());
+ Assertions.assertThat(iterator.next()).isEqualTo(expectedRecord);
+ Assertions.assertThat(iterator.hasNext()).isFalse();
Review Comment:
```suggestion
Assertions.assertThat(iterator).isExhausted();
```
##########
data/src/test/java/org/apache/iceberg/data/TestLocalScan.java:
##########
@@ -401,15 +391,15 @@ public void testProjectWithMissingFilterColumn() {
}
results.forEach(
- record -> Assert.assertEquals("Record should have two projected
fields", 2, record.size()));
+ record -> Assertions.assertThat(record.size()).as("Record should have
two projected fields").isEqualTo(2));
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
