nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584246393
##########
data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java:
##########
@@ -217,10 +214,11 @@ public void testEqualityDeletePlanningStatsFilter()
throws IOException {
tasks = Lists.newArrayList(tasksIterable);
}
- Assert.assertEquals("Should produce one task", 1, tasks.size());
+ Assertions.assertThat(tasks.size()).isEqualTo(1).as("Should produce one
task");
Review Comment:
we typically want to use `assertThat(tasks).hasSize(x)` as that will show
the content of the collection if the assertion ever fails. Using
`assertThat(tasks.size()).isEqualTo(x)` will only say `x != size` but you won't
know the content
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
