nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584243797
##########
data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java:
##########
@@ -217,10 +214,11 @@ public void testEqualityDeletePlanningStatsFilter()
throws IOException {
tasks = Lists.newArrayList(tasksIterable);
}
- Assert.assertEquals("Should produce one task", 1, tasks.size());
+ Assertions.assertThat(tasks.size()).isEqualTo(1).as("Should produce one
task");
FileScanTask task = tasks.get(0);
- Assert.assertEquals(
- "Should not have delete file, filtered by data column stats", 0,
task.deletes().size());
+ Assertions.assertThat(task.deletes().size())
+ .isEqualTo(0)
+ .as("Should not have delete file, filtered by data column stats");
Review Comment:
`.as()` needs to come before `.isEqualTo()`, otherwise it will be just
ignored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
