nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568292423
##########
data/src/test/java/org/apache/iceberg/data/TestReadProjection.java:
##########
@@ -76,20 +78,21 @@ public void testSpecialCharacterProjection() throws
Exception {
Record full = writeAndRead("special_chars", schema, schema, record);
- Assert.assertEquals(
- "Should contain the correct id value", 34L, (long) full.getField("user
id"));
- Assert.assertEquals(
- "Should contain the correct data value",
- 0,
- Comparators.charSequences().compare("test", (CharSequence)
full.getField("data%0")));
+ Assertions.assertThat((long) full.getField("user id"))
+ .isEqualTo(34L)
+ .describedAs("Should contain the correct id value");
Review Comment:
this should be rather `.as(..)` and should come before the final assertion.
Also please update all the other places in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
