nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568270818
##########
data/src/test/java/org/apache/iceberg/data/TestLocalScan.java:
##########
@@ -281,36 +272,36 @@ public void testFullScan() {
expected.addAll(file3FirstSnapshotRecords);
Set<Record> records = Sets.newHashSet(results);
- Assert.assertEquals(
- "Should produce correct number of records", expected.size(),
records.size());
- Assert.assertEquals("Random record set should match",
Sets.newHashSet(expected), records);
+ Assertions.assertThat(expected)
+ .hasSize(records.size())
+ .as("Should produce correct number of records");
+ Assertions.assertThat(records)
+ .isEqualTo(Sets.newHashSet(expected))
+ .as("Random record set should match");
Review Comment:
same as above. Please also make sure this is fixed in all the other places
in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
