nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1568266969
##########
data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java:
##########
@@ -137,9 +135,11 @@ public void testPositionDeletePlanningPath() throws
IOException {
tasks = Lists.newArrayList(tasksIterable);
}
- Assert.assertEquals("Should produce one task", 1, tasks.size());
+ Assertions.assertThat(tasks).as("Should produce one task").hasSize(1);
FileScanTask task = tasks.get(0);
- Assert.assertEquals("Should have one delete file, file_path matches", 1,
task.deletes().size());
+ Assertions.assertThat(task.deletes().size())
Review Comment:
should be `Assertions.assertThat(task.deletes()).as(...).hasSize(1)`,
because the `.as(..)` needs to come before the final assertion
##########
data/src/test/java/org/apache/iceberg/data/TestDataFileIndexStatsFilters.java:
##########
@@ -151,7 +151,7 @@ public void testPositionDeletePlanningPathFilter() throws
IOException {
deletes.add(Pair.of("some-other-file.parquet", 1L));
Pair<DeleteFile, CharSequenceSet> posDeletes =
- FileHelpers.writeDeleteFile(table, Files.localOutput(temp.newFile()),
deletes);
+ FileHelpers.writeDeleteFile(table, Files.localOutput(temp), deletes);
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
