tomtongue commented on code in PR #10086:
URL: https://github.com/apache/iceberg/pull/10086#discussion_r1555517972
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##########
@@ -258,10 +247,10 @@ public void testRenameTableFailsToCreateNewTable() {
.hasMessageContaining("Table already exists");
// old table can still be read with same metadata
Table oldTable = glueCatalog.loadTable(id);
- Assert.assertEquals(table.location(), oldTable.location());
- Assert.assertEquals(table.schema().toString(),
oldTable.schema().toString());
- Assert.assertEquals(table.spec(), oldTable.spec());
- Assert.assertEquals(table.currentSnapshot(), oldTable.currentSnapshot());
+ assertThat(oldTable.location()).isEqualTo(table.location());
+
assertThat(oldTable.schema()).asString().isEqualTo(table.schema().toString());
Review Comment:
As commented above, it's necessary because the testing the comparisons
between objects fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
