nk1506 commented on code in PR #10086:
URL: https://github.com/apache/iceberg/pull/10086#discussion_r1555513397
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##########
@@ -229,10 +218,10 @@ public void testRenameTable() {
glueCatalog.renameTable(
TableIdentifier.of(namespace, tableName),
TableIdentifier.of(namespace, newTableName));
Table renamedTable = glueCatalog.loadTable(TableIdentifier.of(namespace,
newTableName));
- Assert.assertEquals(table.location(), renamedTable.location());
- Assert.assertEquals(table.schema().toString(),
renamedTable.schema().toString());
- Assert.assertEquals(table.spec(), renamedTable.spec());
- Assert.assertEquals(table.currentSnapshot(),
renamedTable.currentSnapshot());
+ assertThat(renamedTable.location()).isEqualTo(table.location());
+
assertThat(renamedTable.schema()).asString().isEqualTo(table.schema().toString());
Review Comment:
nit: Just wondering why cast to `asString()` here ? Other Object comparison
we are doing using `isEqualTo`
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##########
@@ -258,10 +247,10 @@ public void testRenameTableFailsToCreateNewTable() {
.hasMessageContaining("Table already exists");
// old table can still be read with same metadata
Table oldTable = glueCatalog.loadTable(id);
- Assert.assertEquals(table.location(), oldTable.location());
- Assert.assertEquals(table.schema().toString(),
oldTable.schema().toString());
- Assert.assertEquals(table.spec(), oldTable.spec());
- Assert.assertEquals(table.currentSnapshot(), oldTable.currentSnapshot());
+ assertThat(oldTable.location()).isEqualTo(table.location());
+
assertThat(oldTable.schema()).asString().isEqualTo(table.schema().toString());
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
