nk1506 commented on code in PR #10086:
URL: https://github.com/apache/iceberg/pull/10086#discussion_r1555586399
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##########
@@ -229,10 +218,10 @@ public void testRenameTable() {
glueCatalog.renameTable(
TableIdentifier.of(namespace, tableName),
TableIdentifier.of(namespace, newTableName));
Table renamedTable = glueCatalog.loadTable(TableIdentifier.of(namespace,
newTableName));
- Assert.assertEquals(table.location(), renamedTable.location());
- Assert.assertEquals(table.schema().toString(),
renamedTable.schema().toString());
- Assert.assertEquals(table.spec(), renamedTable.spec());
- Assert.assertEquals(table.currentSnapshot(),
renamedTable.currentSnapshot());
+ assertThat(renamedTable.location()).isEqualTo(table.location());
+
assertThat(renamedTable.schema()).asString().isEqualTo(table.schema().toString());
Review Comment:
Yeah Just wondering , Why PartiotionSpec and Snapshot comparison are
working.
As per my understanding `isEqualTo` compares object values. So ideally it
should not fail unless I am missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
