nastra commented on code in PR #10086:
URL: https://github.com/apache/iceberg/pull/10086#discussion_r1555315428
##########
aws/src/integration/java/org/apache/iceberg/aws/lakeformation/TestLakeFormationAwsClientFactory.java:
##########
@@ -165,7 +165,8 @@ public void testLakeFormationEnabledGlueCatalog() throws
Exception {
glueCatalog.createNamespace(allowedNamespace);
} catch (GlueException e) {
LOG.error("fail to create Glue database", e);
- Assert.fail("create namespace should succeed");
+
+ fail("create namespace should succeed");
Review Comment:
rather than using `fail` with a try-catch, it's better to have something
like `assertThatNoException().isThrownBy(() ->
glueCatalog.createNamespace(allowedNamespace))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
