tomtongue commented on code in PR #10086:
URL: https://github.com/apache/iceberg/pull/10086#discussion_r1555216313
##########
aws/src/integration/java/org/apache/iceberg/aws/TestDefaultAwsClientFactory.java:
##########
@@ -39,7 +40,7 @@ public void testGlueEndpointOverride() {
properties.put(AwsProperties.GLUE_CATALOG_ENDPOINT,
"https://unknown:1234";);
AwsClientFactory factory = AwsClientFactories.from(properties);
GlueClient glueClient = factory.glue();
- Assertions.assertThatThrownBy(
+ assertThatThrownBy(
Review Comment:
I believe the changes for removing `Assertion` are very small in this
package, and by the changes, it can avoid the situation that two methods like
`Assertions.assertThat` and `assertThat` exist in a same file. So it won't be a
big problem. If there's any reason to keep `Assertions`, please let me know.
[Iceberg contribute guide](https://iceberg.apache.org/contribute/#assertj)
also shows the tests without `Assertions` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
