snazy commented on code in PR #9940:
URL: https://github.com/apache/iceberg/pull/9940#discussion_r1524318797
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1559,6 +1578,22 @@ components:
type: string
description:
Properties that should be used as default configuration; applied
before client configuration.
+ capabilities:
+ type: array
+ uniqueItems: true
+ items:
+ type: string
+ enum:
Review Comment:
> In the spec this is just an enumeration of options. The actual impl will
make sure that this is forward/backward compatible.
> All of this will be handled at the JSON level when parsing capabilities in
a ConfigResponse.
You're focused on Java with a lot of custom and manual parsing code here.
This enum becomes a _language native_ enum. So all other languages need to
implement custom logic. Even partial code generation becomes impossible - or is
at high risk of being broken.
Adding another value would violate the (older) open-api spec of older
clients/servers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
