snazy commented on code in PR #9940:
URL: https://github.com/apache/iceberg/pull/9940#discussion_r1534219425


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1559,6 +1578,22 @@ components:
             type: string
           description:
             Properties that should be used as default configuration; applied 
before client configuration.
+        capabilities:
+          type: array
+          uniqueItems: true
+          items:
+            type: string
+            enum:

Review Comment:
   I'm still not convinced that using `enum` here, especially for capabilities 
that change over time, is a good choice. Validations will legitly fail - and 
partly generated code as well - breaking back/forward  compatibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to