nastra commented on PR #9940: URL: https://github.com/apache/iceberg/pull/9940#issuecomment-2025004545
> If I'm correct this approach provides a way to group catalog functionalities, and allow the server to explicitly define the support or not. This is kind of similar to what both the append and scan API's were trying to do with the feature flag configs. However, there was one potential issue with using the config, as they could be incorrectly set upon catalog initialization, and the client may still make a request to an unsupported endpoint where a server doesn't explicitly set the flag to false in the `getConfig` response. > > On that note if the server specifies no support for a feature, and we failing early on the client side? In this case here we don't set feature flags with true/false. The existence of a capability in `capabilities` means that a server supports it. In the absence of a capability, a client would not call the respective endpoint or throw an errror. For views there are cases where a client wouldn't call the endpoint (e.g. when renaming a table, it wouldn't also check if a view with the same name exists). In other cases the client would fail early, indicating that the server doesn't support X. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
